Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ private bool TryLoadAssetsFile(IProject project, [NotNullWhen(true)] out ILockFi
}
assetsFile = _lockFileFactory.GetFromFile(assetsPath);

if (assetsFile.TryGetErrors(out string[] errors))
{
throw new ReferencedPackageReaderException($"Project assets file for project {project.FullPath} contains errors:{Environment.NewLine}{string.Join(Environment.NewLine, errors)}");
}

if (!assetsFile.PackageSpec.IsValid() || !(assetsFile.Targets?.Any() ?? false))
{
throw new ReferencedPackageReaderException(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ namespace NuGetUtility.Wrapper.NuGetWrapper.ProjectModel
{
public interface ILockFile
{
bool TryGetErrors(out string[] errors);
IPackageSpec PackageSpec { get; }
IEnumerable<ILockFileTarget>? Targets { get; }
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,12 @@ public WrappedLockFile(LockFile file)

public IPackageSpec PackageSpec => new WrappedPackageSpec(_file.PackageSpec);
public IEnumerable<ILockFileTarget>? Targets => _file.Targets?.Select(t => new WrappedLockFileTarget(t));

public bool TryGetErrors(out string[] errors)
{
IAssetsLogMessage[] fileErrors = _file.LogMessages.Where(l => l.Level == NuGet.Common.LogLevel.Error).ToArray();
errors = fileErrors.Select(e => $"[{e.Code}] {e.Message}").ToArray();
return errors.Length > 0;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,24 @@ public void SetUp()
private IDictionary<INuGetFramework, PackageIdentity[]> _referencedPackagesForFramework = null!;
private IDictionary<INuGetFramework, PackageIdentity[]> _directlyReferencedPackagesForFramework = null!;

[Test]
public void GetInstalledPackages_Should_ThrowReferencedPackageReaderException_If_AssetsFileContainsErrors(
[Values] bool includeTransitive)
{
string[] errors = _fixture.CreateMany<string>().ToArray();
_lockFileMock.TryGetErrors(out Arg.Any<string[]>()).Returns(args =>
{
args[0] = errors;
return true;
});
_projectMock.FullPath.Returns(_projectPath);

ReferencedPackageReaderException? exception = Assert.Throws<ReferencedPackageReaderException>(() =>
_uut.GetInstalledPackages(_projectPath, includeTransitive));

Assert.That(exception!.Message, Is.EqualTo($"Project assets file for project {_projectPath} contains errors:{Environment.NewLine}{string.Join(Environment.NewLine, errors)}"));
}

[Test]
public void GetInstalledPackages_Should_ThrowReferencedPackageReaderException_If_PackageSpecificationIsInvalid(
[Values] bool includeTransitive)
Expand Down