Add/license url override#102
Merged
Merged
Conversation
|
sensslen
requested changes
Nov 7, 2024
Owner
|
@pymenguy are you still interested in driving this PullRequest over the finish line? |
|
Hey, Could this feature please be added? I also encountered a use case where I needed to override the URL, too. If the original PR contributor is not willing to finish it, I suggest you add the test yourself afterward (if it is only the test that is missing). Appreciate your work on this tool! Keep it coming. |
Owner
|
@paulbuechner @pymenguy this feature has now been merged to main. It has not made it's way to a release. I'm bundling this with slnx support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hello,
When testing the capabilities of the tool, I noticed the URL could not be overridden by the option "override-package-information".
For many reasons URLs may be broken (domain name changing/expiring, changing SCM provider, etc). If we were to attempt the download of the original license, it would fail.
One such package I encountered is SharpDX, which still has the invalid URL linked on nuget.org :
Following what was written in #53 and #68 I also added the LicenceUrl to the list of fields and to the tests.