Skip to content

Add/license url override#102

Merged
sensslen merged 2 commits into
sensslen:mainfrom
pymenguy:add/license_url_override
Feb 3, 2025
Merged

Add/license url override#102
sensslen merged 2 commits into
sensslen:mainfrom
pymenguy:add/license_url_override

Conversation

@pymenguy
Copy link
Copy Markdown

@pymenguy pymenguy commented Nov 7, 2024

Hello,

When testing the capabilities of the tool, I noticed the URL could not be overridden by the option "override-package-information".

For many reasons URLs may be broken (domain name changing/expiring, changing SCM provider, etc). If we were to attempt the download of the original license, it would fail.

One such package I encountered is SharpDX, which still has the invalid URL linked on nuget.org :

Following what was written in #53 and #68 I also added the LicenceUrl to the list of fields and to the tests.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 7, 2024

@sensslen sensslen self-requested a review November 7, 2024 15:46
Copy link
Copy Markdown
Owner

@sensslen sensslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. Would you mind adding a test that verifies that the LicenseUrl ends up in the override package information?

@sensslen
Copy link
Copy Markdown
Owner

@pymenguy are you still interested in driving this PullRequest over the finish line?

@paulbuechner
Copy link
Copy Markdown

Hey,

Could this feature please be added? I also encountered a use case where I needed to override the URL, too.

If the original PR contributor is not willing to finish it, I suggest you add the test yourself afterward (if it is only the test that is missing).

@pymenguy @sensslen

Appreciate your work on this tool! Keep it coming.

@sensslen sensslen merged commit d503079 into sensslen:main Feb 3, 2025
@sensslen
Copy link
Copy Markdown
Owner

sensslen commented Feb 3, 2025

@paulbuechner @pymenguy this feature has now been merged to main. It has not made it's way to a release. I'm bundling this with slnx support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants