Allow to skip ADC setup. #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. for compatibility with certain libraries, or to enable techniques such as analog port multiplexing. Note that this is a runtime solution. On the positive side, users can select to skip ADC setup per sketch, without making any changes in the lib. On the negative side (compared to a compile-time switch), this solution does not save any allocated RAM, and the ISR routine is still defined on platforms that define it.
tfry-git
force-pushed
the
work/no_adc_option
branch
from
2c184b4 to
35b134c
Compare
Collaborator
Author
|
Closing in favor of #211 , which adds a compile time option to this effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. for compatibility with certain libraries, or to enable techniques such as
analog port multiplexing.
Note that this is a run time solution. On the positive side, users can select to
skip ADC setup per sketch, without making any changes in the lib. On the negative side
(compared to a compile-time switch), this solution does not save any allocated RAM, and
the ISR routine is still defined on platforms that define it.
---- For some more background:
I had stumbled across this before. My present issue was that I tried to get a resistive touchscreen to work on an STM32F103C8T6, but this turned out to be impossible in conjunction with Mozzi. Use-cases like this are going to become more widespread on the more powerful platforms. But even on 8bit AVRs, there are cases, where users will need custom analogRead()s - e.g. from the PotMUX library.