This repository was archived by the owner on Jan 6, 2020. It is now read-only.
Removed AcmeDemoBundle from the regular Symfony distribution #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fony_Demo version
Closed
|
Nice proposal, I agree with @javiereguiluz ! |
|
Totally agree. We should remove that! |
|
Me parece genial! |
|
+1 |
7 similar comments
|
+1 |
|
👍 |
|
+1 |
|
+1 |
Contributor
|
+1 |
|
👍 |
|
+1 |
|
Of course, +10000 |
|
+1 |
10 similar comments
|
+1 |
|
+1 |
|
+1 |
|
👍 |
|
+1 |
|
+1 |
|
+1 |
|
👍 |
|
+1 |
|
+1 |
Contributor
|
+1 Why not offering the AcmeDemoBundle as a Composer package or having a Symfony Demo Edition? |
Contributor
Author
|
@hhamon that's exactly we're trying to do at the moment:
We'll provide soon a new |
|
👍 |
Member
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Mar 25, 2015
…tion (javiereguiluz) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #198). Discussion ---------- Removed AcmeDemoBundle from the regular Symfony distribution ## The problem The new Symfony Installer downloads the Symfony packages created with these scripts. The problem is that they include the AcmeDemoBundle which all non-newcomer Symfony developers want to remove. ## The proposed solution * The AcmeDemoBundle is no longer included in the regular Symfony distribution. This way the installer creates a fresh and empty Symfony application. This is the last feature to finish the installer. * A new script (`build_demo.sh`) creates a new `Symfony_Demo.zip` file which contains the latest stable version of Symfony and the AcmeDemoBundle. This is the package that we'd promote for newcomers and it would allow us to improve the AcmeDemoBundle to include more features and better explanations. Commits ------- 5ba1f73 Removed AcmeDemoBundle from the regular Symfony distribution
fabpot
added a commit
that referenced
this pull request
Jun 11, 2015
…le (javiereguiluz) This PR was squashed before being merged into the 4.0.x-dev branch (closes #212). Discussion ---------- Remove everything related to the deprecated AcmeDemoBundle ### The context `AcmeDemoBundle` is deprecated because of the new [SymfonyDemoApplication](https://github.com/symfony/symfony-demo). This bundle should no longer appear when creating a project with the Symfony Standard Edition (no matter if you use the Symfony Installer or the Composer installation). ### The problem In the past I tried to remove this bundle (see #198). However, when you install Symfony you still get this annoying bundle, so you cannot get a fresh clean Symfony installation. ### The solution I propose to remove the AcmeDemoBundle for once and for all by removing all its files. Please note that in the `Composer/ScriptHandler.php` there are two methods called `installAcmeDemoBundle()` and `patchAcmeDemoBundleConfiguration()` which I've emptied but left for BC reasons. @stof do you think we could removed these two methods entirely? Thanks. Commits ------- 29a1a2b Remove everything related to the deprecated AcmeDemoBundle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The new Symfony Installer downloads the Symfony packages created with these scripts. The problem is that they include the AcmeDemoBundle which all non-newcomer Symfony developers want to remove.
The proposed solution
build_demo.sh) creates a newSymfony_Demo.zipfile which contains the latest stable version of Symfony and the AcmeDemoBundle. This is the package that we'd promote for newcomers and it would allow us to improve the AcmeDemoBundle to include more features and better explanations.