Skip to content

test: Add unit test for license year #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbernier merged 3 commits into from
Nov 21, 2017
Merged

test: Add unit test for license year #45

mbernier merged 3 commits into from
Nov 21, 2017

Conversation

@pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 29, 2017 •
edited
Loading

Fixes #39

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • add unit test for check of license year

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@pushkyn pushkyn force-pushed the add-test-license-year branch 2 times, most recently from 106bd3c to eb3eb29 Compare October 29, 2017 22:26
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@pushkyn pushkyn force-pushed the add-test-license-year branch from eb3eb29 to bb9f452 Compare November 3, 2017 21:04
@mbernier mbernier added the difficulty: medium fix is medium in difficulty label Nov 21, 2017
@mbernier mbernier merged commit 533be11 into sendgrid:master Nov 21, 2017
@thinkingserious
Copy link
Contributor

thinkingserious commented Nov 21, 2017

Hello @pushkyn,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title Add unit test for license year test: Add unit test for license year Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range

4 participants

@pushkyn @thinkingserious @mbernier @apigirl