Skip to content

test: Added unittest to check for specific repo files #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Oct 28, 2017

Fixes # #58

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@mptap mptap force-pushed the add-test-files-exist branch from 7e7e894 to d85448b Compare October 28, 2017 18:38
@mbernier
Copy link
Contributor

BEAUTIFULLY done!

This is awesome. Thank you so much!!

Just so you know, we have this same issue on another Node library if you're interested:

@mptap mptap force-pushed the add-test-files-exist branch from d85448b to d206e6d Compare October 28, 2017 18:52
@mbernier mbernier merged commit 74126a4 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Added unittest to check for specific repo files test: Added unittest to check for specific repo files Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants