Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add a .env_sample file and update gitignore #49

Merged
merged 2 commits into from
Oct 30, 2017
Merged

docs: Add a .env_sample file and update gitignore #49

merged 2 commits into from
Oct 30, 2017

Conversation

thepriefy
Copy link
Contributor

issue #45

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2017
@thepriefy thepriefy changed the title Add a .env_sample file, update gitignore, update README,md Add a .env_sample file, update gitignore, update README.md Oct 27, 2017
@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
mbernier
mbernier suggested changes Oct 29, 2017
View reviewed changes
README.md Outdated
### Initial Setup

```bash
cp .env_sample .env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are doing this step, then all you need to do is open and edit the file by inserting your API KEY.

The next section environment variable is redundant.

@thepriefy
Copy link
Contributor Author

thepriefy commented Oct 29, 2017 •
edited
Loading

I've done what you requested. Is that ok?
(I don't know why the build fails. I there is anything I did in the wrong way, please tell me.)
@mbernier

@mbernier
Copy link
Contributor

This is good to go, the build is failing because we added a check for files in the repo (like this one that you added). Thanks!

@mbernier mbernier merged commit 4dc6842 into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thepriefy thepriefy deleted the priefy-issue-45-1 branch November 29, 2017 01:31
@mauricetmeyer mauricetmeyer mentioned this pull request Oct 11, 2018
Closed
6 tasks
@childish-sambino childish-sambino changed the title Add a .env_sample file, update gitignore, update README.md docs: Add a .env_sample file and update gitignore Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thepriefy @mbernier @thinkingserious