Skip to content

fix: Freeze dev dependencies so tests pass on 10.x #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

mgingras
Copy link
Contributor

Freezing dependencies to a version should keep tests passing on both all supported versions

Closes #36

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 27, 2017
@mbernier
Copy link
Contributor

Solid!

@mbernier mbernier merged commit f3135fe into sendgrid:master Oct 27, 2017
@thinkingserious
Copy link
Contributor

Hello @mgingras,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Freeze dev dependencies so tests pass on 10.x fix: Freeze dev dependencies so tests pass on 10.x Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm test is failing on older NodeJs versions due to const declaration
3 participants