Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue where concat was used incorrectly #16

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

limianwang
Copy link
Contributor

No description provided.

@limianwang
Copy link
Contributor Author

It would be great if we can merge this and publish. Thanks!

@limianwang
Copy link
Contributor Author

@eddiezane Wondering if you (or anyone else with admin) can do a quick code-review and merge? Thanks!

@eddiezane
Copy link
Contributor

Thanks for the ping, @limianwang!

Apologies but I don't work for SendGrid any more.

@thinkingserious or @mbernier might be able to help out though.

@limianwang
Copy link
Contributor Author

Thanks!

@thinkingserious @mbernier Can one of you review this? I'm kind of depending on this module.

@thinkingserious
Copy link
Contributor

Hello @limianwang,

Thanks for the pull request and apologies for the delay!

Please submit a signed CLA so we can get this merged: https://github.com/sendgrid/smtpapi-nodejs/blob/master/CONTRIBUTING.md#cla

Thank you for your support!

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla needed labels May 22, 2016
@thinkingserious
Copy link
Contributor

Hello @limianwang,

Just checking in :)

@limianwang
Copy link
Contributor Author

@thinkingserious ah sorry for the delay, somehow didn't see this notifications. Is that supposed to be email version?

@thinkingserious
Copy link
Contributor

@limianwang,

Yes, please email the signed CLA to [email protected]. Thanks!

@limianwang
Copy link
Contributor Author

@thinkingserious Done.

@thinkingserious thinkingserious added status: cla signed status: work in progress Twilio or the community is in the process of implementing and removed status: cla needed labels Oct 25, 2016
@thinkingserious thinkingserious merged commit f2c16c4 into sendgrid:master Apr 11, 2017
@thinkingserious
Copy link
Contributor

Hello @limianwang,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants