fix: Accurate duplicate checking when adding email to Personalizations (

#446)

lib/sendgrid/helpers/mail/personalization.rb

@@ -76,7 +76,7 @@ def duplicate?(addition)
       additional_email = addition.email.downcase
 
       [@tos, @ccs, @bccs].flatten.each do |elm|
-        return true if elm&.dig('email') == additional_email
+        return true if elm&.dig('email')&.downcase == additional_email
       end
 
       false

test/sendgrid/helpers/mail/test_personalizations.rb

@@ -26,6 +26,7 @@ def test_add_to
   def test_duplicate_add_to
     @personalization = Personalization.new
     @personalization.add_to(Email.new(email: '[email protected]', name: 'Example User'))
+    @personalization.add_to(Email.new(email: '[email protected]', name: 'Example User 2'))
 
     assert_raises(DuplicatePersonalizationError) do
       @personalization.add_to(Email.new(email: '[email protected]', name: 'Duplicate User'))
@@ -34,6 +35,14 @@ def test_duplicate_add_to
     assert_raises(DuplicatePersonalizationError) do
       @personalization.add_to(Email.new(email: '[email protected]', name: 'Duplicate User'))
     end
+
+    assert_raises(DuplicatePersonalizationError) do
+      @personalization.add_to(Email.new(email: '[email protected]', name: 'Duplicate User 2'))
+    end
+
+    assert_raises(DuplicatePersonalizationError) do
+      @personalization.add_to(Email.new(email: '[email protected]', name: 'Duplicate User 2'))
+    end
   end
 
   def test_add_cc
@@ -58,6 +67,7 @@ def test_add_cc
   def test_duplicate_add_cc
     @personalization = Personalization.new
     @personalization.add_cc(Email.new(email: '[email protected]', name: 'Example User'))
+    @personalization.add_cc(Email.new(email: '[email protected]', name: 'Example User 2'))
 
     assert_raises(DuplicatePersonalizationError) do
       @personalization.add_cc(Email.new(email: '[email protected]', name: 'Duplicate User'))
@@ -66,6 +76,14 @@ def test_duplicate_add_cc
     assert_raises(DuplicatePersonalizationError) do
       @personalization.add_cc(Email.new(email: '[email protected]', name: 'Duplicate User'))
     end
+
+    assert_raises(DuplicatePersonalizationError) do
+      @personalization.add_cc(Email.new(email: '[email protected]', name: 'Duplicate User 2'))
+    end
+
+    assert_raises(DuplicatePersonalizationError) do
+      @personalization.add_cc(Email.new(email: '[email protected]', name: 'Duplicate User 2'))
+    end
   end
 
   def test_add_bcc
@@ -90,6 +108,7 @@ def test_add_bcc
   def test_duplicate_add_bcc
     @personalization = Personalization.new
     @personalization.add_bcc(Email.new(email: '[email protected]', name: 'Example User'))
+    @personalization.add_bcc(Email.new(email: '[email protected]', name: 'Example User 2'))
 
     assert_raises(DuplicatePersonalizationError) do
       @personalization.add_bcc(Email.new(email: '[email protected]', name: 'Duplicate User'))
@@ -98,6 +117,14 @@ def test_duplicate_add_bcc
     assert_raises(DuplicatePersonalizationError) do
       @personalization.add_bcc(Email.new(email: '[email protected]', name: 'Duplicate User'))
     end
+
+    assert_raises(DuplicatePersonalizationError) do
+      @personalization.add_bcc(Email.new(email: '[email protected]', name: 'Duplicate User 2'))
+    end
+
+    assert_raises(DuplicatePersonalizationError) do
+      @personalization.add_bcc(Email.new(email: '[email protected]', name: 'Duplicate User 2'))
+    end
   end
 
   def test_add_header