Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up sendgrid.py #844

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Conversation

Aman-am
Copy link
Contributor

@Aman-am Aman-am commented Oct 9, 2019

Minor Change

Fixes #X

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Twilio SendGrid, or file a GitHub Issue in this repository.

Minor Change
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #844 into master will increase coverage by 2.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
+ Coverage   80.02%   82.41%   +2.38%     
==========================================
  Files          70       70              
  Lines        2018     2303     +285     
  Branches      339      338       -1     
==========================================
+ Hits         1615     1898     +283     
- Misses        204      206       +2     
  Partials      199      199
Impacted Files Coverage Δ
sendgrid/sendgrid.py 83.33% <ø> (ø) ⬆️
sendgrid/helpers/mail/email.py 93.4% <0%> (-1.66%) ⬇️
sendgrid/version.py 100% <0%> (ø) ⬆️
sendgrid/helpers/inbound/send.py 93.93% <0%> (+0.18%) ⬆️
sendgrid/helpers/inbound/config.py 97.5% <0%> (+0.44%) ⬆️
sendgrid/helpers/mail/spam_check.py 95.45% <0%> (+0.71%) ⬆️
sendgrid/helpers/mail/ganalytics.py 96.82% <0%> (+0.74%) ⬆️
sendgrid/helpers/mail/subject.py 95.65% <0%> (+0.91%) ⬆️
sendgrid/helpers/mail/groups_to_display.py 93.33% <0%> (+1.02%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c500f4...14694a5. Read the comment docs.

import python_http_client


class SendGridAPIClient(object):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you'll use a good linter like python-black. It'll automatically handle all these things and also the two-line gap before python classes are best practices. You may have a look at other files too.

@childish-sambino childish-sambino changed the title Update Sendgrid.py chore: Clean up sendgrid.py Feb 26, 2020
@childish-sambino childish-sambino merged commit 83e25d3 into sendgrid:master Feb 26, 2020
@thinkingserious
Copy link
Contributor

Hello @Aman-am,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Aman-am
Copy link
Contributor Author

Aman-am commented Feb 27, 2020

Hello @thinkingserious

Thanks for merging my PR and your appreciation. I've filled out the form.

Regards
Aman Mehta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants