Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Error Message Section #763

Closed
wants to merge 2 commits into from
Closed

Updated Error Message Section #763

wants to merge 2 commits into from

Conversation

FFX01
Copy link

@FFX01 FFX01 commented Mar 15, 2019

  • Fixed python 3 example print syntax
  • updated exception clause.
  • added link to exception definitions.

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixes Troubleshooting documentation regarding HTTP request exceptions.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

* Fixed python 3 example print syntax
* updated exception clause.
* added link to exception definitions.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 15, 2019
@SendGridDX
Copy link

SendGridDX commented Mar 15, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #763 into v4 will increase coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4     #763      +/-   ##
==========================================
+ Coverage   75.84%   77.26%   +1.41%     
==========================================
  Files          69       38      -31     
  Lines        2012     1205     -807     
  Branches      338      172     -166     
==========================================
- Hits         1526      931     -595     
+ Misses        307      171     -136     
+ Partials      179      103      -76
Impacted Files Coverage Δ
sendgrid/helpers/mail/html_content.py 40% <0%> (-46.37%) ⬇️
sendgrid/helpers/mail/plain_text_content.py 40% <0%> (-46.37%) ⬇️
sendgrid/helpers/mail/attachment.py 70% <0%> (-14.62%) ⬇️
sendgrid/helpers/mail/spam_check.py 81.25% <0%> (-13.49%) ⬇️
sendgrid/helpers/mail/email.py 86.11% <0%> (-8.7%) ⬇️
sendgrid/helpers/mail/personalization.py 79.54% <0%> (-6.46%) ⬇️
sendgrid/helpers/mail/header.py 85.71% <0%> (-3.58%) ⬇️
sendgrid/helpers/mail/substitution.py 85.71% <0%> (-3.58%) ⬇️
sendgrid/helpers/mail/custom_arg.py 85.71% <0%> (-3.58%) ⬇️
sendgrid/helpers/mail/subject.py 91.66% <0%> (-3.08%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4b1fe...bbd75e3. Read the comment docs.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #763 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #763   +/-   ##
=======================================
  Coverage   75.84%   75.84%           
=======================================
  Files          69       69           
  Lines        2012     2012           
  Branches      338      338           
=======================================
  Hits         1526     1526           
  Misses        307      307           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4b1fe...bbd75e3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants