Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README.md #722

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

rahulpuroht
Copy link
Contributor

@rahulpuroht rahulpuroht commented Oct 30, 2018

Fixes #721

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #722 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   85.03%   85.04%   +0.01%     
==========================================
  Files          35       35              
  Lines        1156     1157       +1     
  Branches      172      172              
==========================================
+ Hits          983      984       +1     
  Misses         90       90              
  Partials       83       83
Impacted Files Coverage Δ
sendgrid/helpers/mail/validators.py 44.44% <0%> (ø) ⬆️
sendgrid/helpers/mail/exceptions.py 66.66% <0%> (ø) ⬆️
sendgrid/helpers/inbound/send.py 93.75% <0%> (ø) ⬆️
sendgrid/helpers/mail/content.py 84.61% <0%> (ø) ⬆️
sendgrid/helpers/inbound/config.py 97.05% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb4cc...1536f51. Read the comment docs.

@thinkingserious
Copy link
Contributor

Hello @rahulpuroht,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 49b9e3f into sendgrid:master Nov 2, 2018
@thinkingserious
Copy link
Contributor

Hello @rahulpuroht,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add our Developer Experience Engineer career opportunity to the README
3 participants