Add params type checking for mail helper methods #720
Conversation
thinkingserious
added
the
status: code review request
|
|
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
+ Coverage 85.03% 85.27% +0.24%
==========================================
Files 35 36 +1
Lines 1156 1216 +60
Branches 172 179 +7
==========================================
+ Hits 983 1037 +54
- Misses 90 94 +4
- Partials 83 85 +2
Continue to review full report at Codecov.
|
thinkingserious
added
difficulty: hard
|
Hello @f1x3d, |
|
Hello @f1x3d, |
|
Hello @thinkingserious, I've filled the form. Thank you so much for joining the Hacktoberfest event and rewarding contributors with some awesome swag! |
| @@ -19,6 +19,7 @@ install: | |||
| - pip install pypandoc | |||
| - pip install coverage | |||
| - pip install codecov | |||
| - pip install wrapt | |||
There was a problem hiding this comment.
Why add a new dependency instead of using built-in decorators?
| if expected_type is str: | ||
| expected_type = six.string_types | ||
|
|
||
| if not isinstance(arg_val, expected_type): |
There was a problem hiding this comment.
I'm worried that this is going to cause more breaking changes than is functionally necessary. For example, with this PR adding strict type checking broke a functional implementation.
|
Closing until PR comments have been addressed. |
Resolves #701
Checklist
Short description of what this PR does:
Since the test coverage was not a part of the issue's acceptance criteria, I've included only one basic test.
Please let me know if you want me to add more tests to cover all methods from the mail helper, which are being type checked now.