Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created First-timers.md File #666

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Created First-timers.md File #666

merged 1 commit into from
Jan 24, 2019

Conversation

jaykay12
Copy link
Contributor

@jaykay12 jaykay12 commented Oct 9, 2018

Fixes #662

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Created Documentation for the First-time Contributors to ease their collaborations in a profound manner

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 9, 2018

CLA assistant check
All committers have signed the CLA.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels Oct 11, 2018
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @jaykay12,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @jaykay12,

Could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@thinkingserious thinkingserious changed the base branch from master to v4 October 23, 2018 17:51
@thinkingserious thinkingserious changed the base branch from v4 to master October 23, 2018 17:52
@jaykay12 jaykay12 changed the base branch from master to v4 October 24, 2018 18:48
@jaykay12 jaykay12 changed the base branch from v4 to master October 24, 2018 18:49
@jaykay12 jaykay12 changed the base branch from master to v4 October 24, 2018 18:53
@jaykay12 jaykay12 changed the base branch from v4 to master October 24, 2018 18:54
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #666 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   85.03%   84.77%   -0.26%     
==========================================
  Files          35       35              
  Lines        1156     1156              
  Branches      172      172              
==========================================
- Hits          983      980       -3     
  Misses         90       90              
- Partials       83       86       +3
Impacted Files Coverage Δ
sendgrid/helpers/mail/spam_check.py 88.46% <0%> (-7.7%) ⬇️
sendgrid/helpers/inbound/config.py 93.93% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb4cc...b3feabe. Read the comment docs.

@jaykay12 jaykay12 changed the base branch from master to v4 October 24, 2018 19:06
@jaykay12
Copy link
Contributor Author

@thinkingserious Done. Base branch changed to v4 👍

@thinkingserious thinkingserious merged commit 19bb394 into sendgrid:v4 Jan 24, 2019
@thinkingserious
Copy link
Contributor

Hello @jaykay12,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants