Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to increase test coverage on config.py #643

Merged

Conversation

zkan
Copy link

@zkan zkan commented Oct 6, 2018

Fixes #420

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Add test to check that it should not set env when env format is invalid.

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 6, 2018
@codecov
Copy link

codecov bot commented Oct 6, 2018

Codecov Report

Merging #643 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
+ Coverage   84.77%   84.86%   +0.08%     
==========================================
  Files          35       35              
  Lines        1156     1156              
  Branches      172      172              
==========================================
+ Hits          980      981       +1     
  Misses         90       90              
+ Partials       86       85       -1
Impacted Files Coverage Δ
sendgrid/helpers/inbound/config.py 96.96% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1627df7...2ba4666. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing hacktoberfest difficulty: medium fix is medium in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious thinkingserious merged commit dd4c66a into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @zkan,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@zkan zkan deleted the add_more_tests_to_increase_code_coverage branch October 28, 2018 01:09
@zkan
Copy link
Author

zkan commented Oct 28, 2018

@thinkingserious Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for config.py
3 participants