Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme #588

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Update Readme #588

merged 3 commits into from
Aug 8, 2018

Conversation

bchandaka
Copy link
Contributor

  • Updates the Readme to include environment variable setup in windows

Fixes #561

@bchandaka
Update Readme
7ccbf5d 
Added windows environment variable setup
@bchandaka
Update README.md
2da51c2 
Added environmental variable setup in windows
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 9, 2018
@SendGridDX
Copy link

SendGridDX commented Jul 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 9, 2018 •
edited
Loading

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          32       32           
  Lines         979      979           
  Branches      131      131           
=======================================
  Hits          848      848           
  Misses         67       67           
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889a3cf...cbd29ac. Read the comment docs.

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: waiting for feedback waiting for feedback from the submitter labels Jul 29, 2018
@af4ro af4ro added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Aug 8, 2018
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Aug 8, 2018
@thinkingserious thinkingserious merged commit b06bc3e into sendgrid:master Aug 8, 2018
@thinkingserious
Copy link
Contributor

Hello @bchandaka,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bchandaka @SendGridDX @thinkingserious @af4ro