Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a little bug in case #429

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Find a little bug in case #429

merged 1 commit into from
Oct 28, 2017

Conversation

daluntw
Copy link
Contributor

@daluntw daluntw commented Oct 24, 2017

Find a little bug in case

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 24, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 24, 2017

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files           9        9           
  Lines         999      999           
  Branches      160      160           
=======================================
  Hits          819      819           
  Misses         90       90           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6114af5...b403045. Read the comment docs.

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 28, 2017
@mbernier mbernier merged commit 07cc373 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @daluntw,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added hacktoberfest status: code review request requesting a community code review or review from Twilio labels Oct 28, 2017
@mbernier
Copy link
Contributor

@daluntw
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@thinkingserious thinkingserious mentioned this pull request Jun 7, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants