Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of reply_to in mail helper #1003

Merged
merged 1 commit into from
Aug 18, 2021
Merged

chore: get rid of reply_to in mail helper #1003

merged 1 commit into from
Aug 18, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke commented Aug 17, 2021

Fixes

Remove duplicated reply_to in the mail helper

Fixes #1001
Revert #999

@JenniferMah JenniferMah merged commit 62d43ed into main Aug 18, 2021
@JenniferMah JenniferMah deleted the fix-mail branch August 18, 2021 17:57
@mikeckennedy
Copy link
Contributor

Hi all. Please be careful here.

A signature change was introduced into the method that broke existing code. We had to scramble to fix our (now broken) site that was backing up with 100s of unsent/failing outbound emails because reply_to was introduced as a non-keyword, no-default parameter. So we discovered this a day later and fixed it.

With this change again, it breaks the exiting code that had to be fixed for the first breaking change. So again, today we wake up to a dashboard full of errors.

Outbound email running on background threads & queues is not entirely obvious that it breaks right away. Please keep this in mind for future changes to the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version breaks Quick Start Guide and possibly other documentation.
3 participants