Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper example still uses v5 api #817

Closed
enugentdt opened this issue Jun 28, 2019 · 0 comments · Fixed by #818
Closed

Helper example still uses v5 api #817

enugentdt opened this issue Jun 28, 2019 · 0 comments · Fixed by #818

Comments

@enugentdt
Copy link
Contributor

Issue Summary

The helpers example README still follows v5 api conventions, and has not updated. I'm including a PR to fix this.

For example:

 mail = Mail(from_email, subject, to_email, content)

should become:

 mail = Mail(from_email, to_email, subject, content)

The above was in the README as an example.

Also, I updated the last code block:
From:

    sg = SendGridAPIClient()
    data = build_kitchen_sink()
    response = sg.client.mail.send.post(request_body=data)

To:

    sg = SendGridAPIClient()
    data = build_kitchen_sink()
    response = sg.send(data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant