Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new API in the helper example #818

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Handle new API in the helper example #818

merged 2 commits into from
Jun 28, 2019

Conversation

enugentdt
Copy link
Contributor

Fixes #817

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works // does this apply?
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This updates the Helper example to follow the v6 API

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 28, 2019
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #818 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          70       70           
  Lines        2018     2018           
  Branches      339      339           
=======================================
  Hits         1615     1615           
  Misses        204      204           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f549dc0...3a96406. Read the comment docs.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: community enhancement feature request not on Twilio's roadmap type: docs update documentation change not affecting the code labels Jun 28, 2019
@thinkingserious thinkingserious merged commit 610e933 into sendgrid:master Jun 28, 2019
@thinkingserious
Copy link
Contributor

Hello @enugentdt,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@enugentdt
Copy link
Contributor Author

Absolutely! Glad to help. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper example still uses v5 api
2 participants