Docker build was fixed in PR #430, but versions >5.2.1 haven't been uploaded

[gabrielkrell]

Issue Summary

A weird bug was discovered in #426 and fixed in #430, but in the meantime builds for 4.2.1 and 4.3.0 failed. Is it possible to backport #430 to the old tags and then re-upload to Docker Hub?

Steps to Reproduce

(See the builds page.)

Technical details:

The rest of the builds were fine, but Docker was broken in builds 4.2.1 and 4.3.0. To get them up, you could:

• Merge Fix #426: Attempt to sync before executing shell command #430 into those releases and re-tag (or increment) to trigger the build. This would also send out release notifications.
• Check out those tags, manually make the change, and manually upload to Docker Hub. Probably the cleanest.

Nontechnical details:

Happy New Year!

[thinkingserious]

Thanks @gabrielkrell! On the backlog ;)

Happy New Year!

[gabrielkrell]

Same to you!

[thinkingserious]

Hi @gabrielkrell,

I hope all is well! It's been a while.

I merged in #430 and it looks like there is still some issue with the Docker build.

If you have a moment, I'd appreciate your insight.

Thanks!

With Best Regards,

Elmer

[gabrielkrell]

Hey @thinkingserious, I've been fine! Same to you; hope all are happy at Sendgrid :). I'll take a look, but it may be some time until I get to it - lots on the backlog right now.

- Gabe

[thinkingserious]

Thanks!

I hope a full backlog means that you are having a great time :)

[Warlord77]

Any one working on this ? @gabrielkrell can you just guide me how to fix this ?

[thinkingserious]

I am about to look into this one, but before I do, are you already working on this @Warlord77?

[childish-sambino]

Closing this out as the root-level Dockerfile is now functioning properly.

[jonodrew]

I seem to be having issues - I think this line requires a folder that's not in the repo.

sendgrid-python/Dockerfile

Line 6 in 50d50d2

COPY prism/prism/nginx/cert.crt /usr/local/share/ca-certificates/cert.crt

I can't find a guide to using Docker on the repo either - all the links seem to be broken.

[childish-sambino]

@jonodrew This should help: https://github.com/sendgrid/sendgrid-python/blob/master/CONTRIBUTING.md#testing

Which links are broken?

[jonodrew]

In https://github.com/sendgrid/sendgrid-python/blob/master/FIRST_TIMERS.md#setting-up-the-development-environment, the link to USAGE.md is broken. With that being said, I then looked at that file and it seemed to be a guide to the API rather than how to set up the container?

With that being said, once I'd run make test-docker the Docker file build itself without any issues on docker build .

[gabrielkrell]

Looks like the language there was copied from the old CONTRIBUTING.md (and would have been referencing the old Docker usage file). The docker/ folder was removed in 91f4cd8. The "Docker" link at the top of the main README is also broken (that "new" section should be removed anyway, it's from 2017).

[childish-sambino]

Old links have now been removed.