Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #426: Attempt to sync before executing shell command #430

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Fix #426: Attempt to sync before executing shell command #430

merged 1 commit into from
Oct 28, 2017

Conversation

aa-dit-yuh
Copy link
Contributor

Fix #426: Attempt to sync before executing shell command

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 24, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 24, 2017

Codecov Report

Merging #430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files           9        9           
  Lines         999      999           
  Branches      160      160           
=======================================
  Hits          819      819           
  Misses         90       90           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6114af5...44e8f6b. Read the comment docs.

@aa-dit-yuh
Copy link
Contributor Author

aa-dit-yuh commented Oct 24, 2017

Please find the succeeding Docker build for this PR

@gabrielkrell
Copy link
Contributor

Good fix to a strange bug. For posterity, here's a big thread where people seem to have discovered it and a few workarounds.

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
@mbernier
Copy link
Contributor

Nice work @narayanaditya95 and thank you for the docs lead @gabrielkrell

For Posterity: WHAT A WEIRD FREAKING BUG.

@mbernier mbernier merged commit ef24b14 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @narayanaditya95,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants