Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "method_count" issue in sendgrid/helpers/mail/personalization.py #487

Closed
thinkingserious opened this issue Oct 29, 2017 · 2 comments
Closed

Fix "method_count" issue in sendgrid/helpers/mail/personalization.py #487

thinkingserious opened this issue Oct 29, 2017 · 2 comments
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Personalization has 24 functions (exceeds 20 allowed). Consider refactoring.

https://codeclimate.com/github/sendgrid/sendgrid-python/sendgrid/helpers/mail/personalization.py#issue_59f5822373ac790001000072
This was referenced Oct 29, 2017
Closed
Closed
Closed
@defaults
Copy link

@thinkingserious This PR fixes some of the codeclimate issues with personalization.py #493.
Also, I found many refactoring and complexity issues in helper files, should I create an issue and fix them.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty labels Feb 27, 2018
@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkingserious @defaults