Skip to content

Fix "method_lines" issue in examples/helpers/mail/mail_example.py #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thinkingserious opened this issue Oct 27, 2017 · 1 comment
Closed

Fix "method_lines" issue in examples/helpers/mail/mail_example.py #460

thinkingserious opened this issue Oct 27, 2017 · 1 comment
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community

Comments

@thinkingserious
Copy link
Contributor

Function build_kitchen_sink has 79 lines of code (exceeds 25 allowed). Consider refactoring.

https://codeclimate.com/github/sendgrid/sendgrid-python/examples/helpers/mail/mail_example.py#issue_59f2b5d5a7918a0001000054
@mbernier mbernier added difficulty: easy fix is easy in difficulty good first issue labels Oct 27, 2017
@suprithcs
Copy link
Contributor

I'll take this. I'll send a pr in few hours.

@suprithcs suprithcs mentioned this issue Oct 28, 2017
Merged
@childish-sambino childish-sambino added status: help wanted requesting help from the community and removed help wanted labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thinkingserious @mbernier @suprithcs @childish-sambino