Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modularize lengthy method #470

Merged
merged 1 commit into from
Oct 28, 2017
Merged

modularize lengthy method #470

merged 1 commit into from
Oct 28, 2017

Conversation

suprithcs
Copy link
Contributor

Fix #460

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@codecov-io
Copy link

codecov-io commented Oct 28, 2017 •
edited
Loading

Codecov Report

Merging #470 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files           9        9           
  Lines        1001     1001           
  Branches      160      160           
=======================================
  Hits          825      825           
  Misses         86       86           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef24b14...ac14b8c. Read the comment docs.

@suprithcs suprithcs force-pushed the refactor branch 2 times, most recently from e5f4cf5 to 60a1d2a Compare October 28, 2017 11:39
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 28, 2017
@mbernier mbernier merged commit 172cb83 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @suprithIUB,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suprithcs @codecov-io @thinkingserious @mbernier