Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct params order in example.php #946

Merged
merged 1 commit into from
Mar 30, 2020
Merged

docs: correct params order in example.php #946

merged 1 commit into from
Mar 30, 2020

Conversation

spaze
Copy link
Contributor

@spaze spaze commented Mar 28, 2020 •
edited
Loading

Fixes

Fixed an example code in example.php which had a wrong params order. Both From and To extend from EmailAddress where $emailAddress is the first param (name second and optional)

sendgrid-php/lib/mail/EmailAddress.php

Lines 47 to 51 in a8468b6

public function __construct(
$emailAddress = null,
$name = null,
$substitutions = null,
$subject = null

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • N/A I have added tests that prove my fix is effective or that my feature works
  • N/A I have added necessary documentation about the functionality in the appropriate .md file
  • N/A I have added inline documentation to the code I modified

@spaze
Correct params order
3ba3395 
Both From and To extend from EmailAddress where $emailAddress is the first param (name second and optional)
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 28, 2020
@childish-sambino childish-sambino merged commit ac693db into sendgrid:master Mar 30, 2020
childish-sambino pushed a commit that referenced this pull request Mar 30, 2020
@spaze
docs: correct params order in example.php (#946)
2dd7c43 
Both From and To extend from EmailAddress where $emailAddress is the first param (name second and optional)
@spaze spaze deleted the patch-1 branch March 30, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaze @childish-sambino @thinkingserious