Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for segments in USAGE.md #839

Merged
merged 1 commit into from
May 15, 2020
Merged

docs: add documentation for segments in USAGE.md #839

merged 1 commit into from
May 15, 2020

Conversation

rwhirn
Copy link
Contributor

@rwhirn rwhirn commented May 14, 2019 •
edited
Loading

Add documentation for "Retrieve recipients matching search criteria using segment conditions"; Enhanced similar documentation for "Create Segment".

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

@rwh-fyp
Add documentation for "Retrieve recipients matching search criteria u…
22e871b 
…sing segment conditions"; Enhanced similar documentation for "Create Segment".
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 14, 2019
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels May 21, 2019
@childish-sambino childish-sambino changed the title Update USAGE.md docs: add documentation for segments in USAGE.md May 15, 2020
childish-sambino
childish-sambino approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino merged commit 1bab426 into sendgrid:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwhirn @childish-sambino @thinkingserious @rwh-fyp