Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more scenarios for email address encoding #756

Merged

Conversation

2mt-heuser
Copy link
Contributor

@2mt-heuser 2mt-heuser commented Oct 24, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Because the current test expected an exception in the middle of the scenario it did never actually reach the other assertions. (it stopped after setting null as name)
I extracted the error cases into their own respective tests and also added more cases for the other parts of the helper

It doesn't address everything in #606, but it's a step in the right direction.

Because the current test expected an exception in the middle of the scenario
it did never actually reach the other assertions.
I extracted the error cases into their own respective tests

Also added more cases for the other parts of the helper
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 24, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Hello @2mt-heuser,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:34
@childish-sambino childish-sambino changed the title Add more scenarios and fix test for valid names test: Add more scenarios for email address encoding Aug 7, 2020
@childish-sambino childish-sambino merged commit 205a444 into sendgrid:main Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants