-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic error in setEmailAddress #740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also use the similar approach to fix this issue.
Hello @smrtab, |
Hello @smrtab, |
Hello @smrtab, |
Fixes #739
Checklist
Short description of what this PR does:
The next condition on line 73 is wrong (file /mail/EmailAddress.php).
if (!is_string($emailAddress) && filter_var($emailAddress, FILTER_VALIDATE_EMAIL))
It turns out that email address shouldn't be a string and should be a valid address simultaneously in order to throw exception.
Probably the right condition is:
if (!(is_string($emailAddress) && filter_var($emailAddress, FILTER_VALIDATE_EMAIL)))
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.