Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mail::setGlobalSubject() #670

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Fix Mail::setGlobalSubject() #670

merged 1 commit into from
Dec 7, 2018

Conversation

smsalisbury
Copy link
Contributor

Fixes #669

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Updates the Mail::setGlobalSubject() to match inline documentation.

Proposed fix for issue #669
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 16, 2018
@SendGridDX
Copy link

SendGridDX commented Aug 16, 2018

CLA assistant check
All committers have signed the CLA.

@jpurpura jpurpura added the difficulty: easy fix is easy in difficulty label Aug 20, 2018
@thinkingserious thinkingserious added the type: bug bug in the library label Aug 21, 2018
@thinkingserious thinkingserious merged commit 8d8bfe0 into sendgrid:master Dec 7, 2018
@thinkingserious
Copy link
Contributor

Hello @smsalisbury,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SendGrid\Mail\Mail::setGlobalSubject() behaves unexpectedly
4 participants