Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try / catch to examples. Fixes #617 #651

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

hjmsw
Copy link
Contributor

@hjmsw hjmsw commented Jul 28, 2018

Fixes #617

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Adds try / catch for all call examples in /examples

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 28, 2018
@hjmsw hjmsw changed the title Add try catch to examples Add try / catch to examples. Fixes #617 Jul 28, 2018
@thinkingserious
Copy link
Contributor

Nice, thanks @hjmsw! This is on our backlog for implementation.

@thinkingserious thinkingserious merged commit 5bf88ef into sendgrid:master Aug 7, 2018
@thinkingserious
Copy link
Contributor

Hello @hjmsw,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the examples in the /examples directory to include try/catch and better printing.
2 participants