Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP Version terms #577

Merged
merged 2 commits into from
Mar 10, 2018
Merged

Update PHP Version terms #577

merged 2 commits into from
Mar 10, 2018

Conversation

ssiddhantsharma
Copy link
Contributor

@ssiddhantsharma ssiddhantsharma commented Feb 6, 2018 •
edited
Loading

Added the latest stable released version - PHP 7.2.x

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@ssiddhantsharma
Update PHP Version terms
3b0f432 
Added the latest stable released version - PHP 7.2.x
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 6, 2018
@thinkingserious
Copy link
Contributor

thinkingserious commented Feb 6, 2018 •
edited
Loading

Thank you for the PR @ssiddhantsharma!

I've added this to our backlog for a merge.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 59ae966 into sendgrid:master Mar 10, 2018
@thinkingserious
Copy link
Contributor

Hello @ssiddhantsharma,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@ssiddhantsharma ssiddhantsharma deleted the patch-6 branch October 23, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssiddhantsharma @thinkingserious