Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit PHP closing tag in use case sample #512

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

dereckson
Copy link
Contributor

Per http://php.net/manual/en/language.basic-syntax.phptags.php it's best to
omit PHP closing tags when a code file is pure PHP to avoid to accidentally
send whitelines to the buffer output, before headers could be sent.

As such, documentation should not use closing tags to reflect best practices.

Per http://php.net/manual/en/language.basic-syntax.phptags.php it's best to
omit PHP closing tags when a code file is pure PHP to avoid to accidentally
send whitelines to the buffer output, before headers could be sent.

As such, documentation should not use closing tags to reflect best practices.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 23, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@dereckson

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Feb 28, 2018
Copy link
Contributor

@ssiddhantsharma ssiddhantsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it is really a DRUPAL or WORDPRESS thing but in some cases omitting the tag is helpful as in, when using include() or require(), so no unwanted whitespaces will be there and you will still be able to add headers to the response later. It is generally a good practice but we should not dive so deep into it.

@thinkingserious thinkingserious merged commit adcc5d6 into sendgrid:master Mar 24, 2018
@thinkingserious
Copy link
Contributor

Hello @dereckson,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants