added support to extend curl options

[ninsuo]

This PR add a curlOptions option to merge custom parameters to curl, and add the ability to set a proxy and/or a timeout.

Should be merged after:
sendgrid/php-http-client#11

[thinkingserious]

This is awesome @ninsuo, thanks!

Can you please sign our CLA so we can get this merged? https://github.com/sendgrid/sendgrid-php/blob/master/CONTRIBUTING.md#cla

With Best Regards,

Elmer

[ninsuo]

Hi,
How to sign it? I don't see a CONTRIBUTORS file?
Thanks

[thinkingserious]

Hi @ninsuo,

You can find the form here: https://drive.google.com/a/sendgrid.com/file/d/0B0PlcM9qA91LN2VEUTJWU2RIVXc/view

Please email the signed version to [email protected]

Thanks!

[ninsuo]

Ok, I'm abroad right now but will see that next week.

A

[thinkingserious]

Thank you @ninsuo!

[thinkingserious]

1. Please change the version back to version 5.1.0
2. Please update the dependency to php-http-client to 3.5

Thanks!

[ninsuo]

Any update on this one?
Thanks

[thinkingserious]

Hi @ninsuo,

I am just awaiting the requested changes:

1. Please change the version back to version 5.1.0
2. Please update the dependency to php-http-client to 3.5

Thanks!

[ninsuo]

Hi mate,

I done those changes more than 20 days ago in 26880af

Please let me know if you need something else

A

[ninsuo]

Hello @thinkingserious

Requested changes are made since 4 weeks now, it becomes urgent to use this feature in our side.

Can you please have a look?

Thanks,

Alain

[thinkingserious]

Hi @ninsuo,

As of right now, this PR is at #7 in our backlog. Apologies for the delay and thanks for the follow up.

[ninsuo]

Hello,

Is it possible to get this merged?

Travis fails because this should be merged after sendgrid/php-http-client#11
But everything is perfectly fine and I should release my project tomorrow.

I'll need to use my fork otherwise, not a good practice.

[thinkingserious]

Hi @ninsuo,

Unfortunately, this one has not bubbled to the top of our backlog just yet, but it is scheduled for a review and merge.

Looking briefly now, I see there are a couple tests passing. I think you might need to update to v5.1.2.

Thanks for checking in and I'm hoping to get this merged soon.

[ninsuo]

Yes you're right, it needed a rebase, that's now ok.

[thinkingserious]

Awesome, thanks for the quick update!

[ninsuo]

No feedback after almost 3 months, we'll be using our branch as the main one in production.
Thanks anyway

[thinkingserious]

@ninsuo,

My apologies :(

I'm glad you got it working in production though.

This is still in our backlog to merge and deploy. Also, for your contribution, we would like to send some swag your way. Could you please fill out this form for us?

Thanks!

[ninsuo]

Please do not merge this one before fixing #17 on php-http-client (i'll need to revert a commit in composer.json).

[thinkingserious]

Thanks for the heads up @ninsuo!

[thinkingserious]

Note: need to merge this one first sendgrid/php-http-client#16

[thinkingserious]

Hi @ninsuo,

We have merged #17 on php-http-client and now this one has come up for merge.

Could you please resolve the conflicts?

Thanks!

With Best Regards,

Elmer

[thinkingserious]

Thanks again for the PR @ninsuo! Please take a moment to fill out this form so we can send you some swag :)