Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added from name for mail api call #3

Closed
wants to merge 1 commit into from
Closed

Added from name for mail api call #3

wants to merge 1 commit into from

Conversation

dmyers
Copy link
Contributor

@dmyers dmyers commented Apr 7, 2012

I wasn't sure how to do toname and replyto because of the way the it opts to not use the to and uses headers if it has an attached file, hopefully someone else can add those.

@cjbuchmann
Copy link
Contributor

Just scanning through this code, I think it looks pretty thorough, but it's missing a small piece. . You've updated the Web library, but not the corresponding SMTP library. In order to get a feature into the this library, we'd like to have it work across both platforms.

For this particular SMTP library, we use a third party library called Swift Mailer. Here's some documentation that will guide you in the right direction : http://swiftmailer.org/docs/messages.html. If you can get that working, we'll push it through our QA review.

Thanks for taking the initiative here!

theycallmeswift added a commit that referenced this pull request Jun 18, 2012
Add optional from name and reply-to fields to web and smtp API calls

Closes #4
Closes #5

WIP #3
@theycallmeswift
Copy link
Contributor

This was fixed by c0da924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants