-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use starkbank/ecdsa 2.1.0 #1111
fix: Use starkbank/ecdsa 2.1.0 #1111
Conversation
@@ -23,6 +24,8 @@ public static function setUpBeforeClass(): void | |||
IW4mdBgQ/7dAfSmpqIM8kF9mN1flpVKS3GRqe62gw+2fNNRaINXvVpiglSI8eNEc6wEA3F+g=='; | |||
self::$SIGNATURE = 'MEUCIGHQVtGj+Y3LkG9fLcxf3qfI10QysgDWmMOVmxG0u6ZUAiE | |||
AyBiXDWzM+uOe5W0JuG+luQAbPIqHh89M15TluLtEZtM='; | |||
self::$BAD_SIGNATURE = 'BADSIGNATURE+Y3LkG9fLcxf3qfI10QysgDWmMOVmxG0u6ZUAiE | |||
AyBiXDWzM+uOe5W0JuG+luQAbPIqHh89M15TluLtEZtM='; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception: missing bytes in DER parse
is thrown if this bad signature isn't in the right format
Can someone please take a look at this PR? Current |
No reviews? Hmm, I think you should email support. |
Let me check |
@simoheinonen some tests seem to fail. Can you check once? |
07a92e1 should do it |
Maybe now? |
Looks good now. Merging |
Thanks guys! |
This should've been at least a minor release change. This package now suddenly requires |
Fixes
This PR bumps the
starkbank/ecdsa
version to^2.1.0
so we get rid of deprecations.Checklist
If you have questions, please file a support ticket.