Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use starkbank/ecdsa 2.1.0 #1111

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

simoheinonen
Copy link
Contributor

Fixes

This PR bumps the starkbank/ecdsa version to ^2.1.0 so we get rid of deprecations.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@@ -23,6 +24,8 @@ public static function setUpBeforeClass(): void
IW4mdBgQ/7dAfSmpqIM8kF9mN1flpVKS3GRqe62gw+2fNNRaINXvVpiglSI8eNEc6wEA3F+g==';
self::$SIGNATURE = 'MEUCIGHQVtGj+Y3LkG9fLcxf3qfI10QysgDWmMOVmxG0u6ZUAiE
AyBiXDWzM+uOe5W0JuG+luQAbPIqHh89M15TluLtEZtM=';
self::$BAD_SIGNATURE = 'BADSIGNATURE+Y3LkG9fLcxf3qfI10QysgDWmMOVmxG0u6ZUAiE
AyBiXDWzM+uOe5W0JuG+luQAbPIqHh89M15TluLtEZtM=';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception: missing bytes in DER parse is thrown if this bad signature isn't in the right format

@simoheinonen simoheinonen changed the title Use starkbank/ecdsa 2.1.0 fix: Use starkbank/ecdsa 2.1.0 Jul 5, 2024
@vincent-lu
Copy link

Can someone please take a look at this PR? Current sendgrid-php is not working with the latest version of starkbank/ecdsa-php library.

See: starkbank/ecdsa-php#23

@54853315
Copy link

No reviews? Hmm, I think you should email support.

@tiwarishubham635
Copy link
Contributor

Let me check

@tiwarishubham635
Copy link
Contributor

@simoheinonen some tests seem to fail. Can you check once?

@simoheinonen
Copy link
Contributor Author

@simoheinonen some tests seem to fail. Can you check once?

07a92e1 should do it

@simoheinonen
Copy link
Contributor Author

Maybe now?

@tiwarishubham635
Copy link
Contributor

Looks good now. Merging

@tiwarishubham635 tiwarishubham635 merged commit bbc26aa into sendgrid:main Nov 25, 2024
7 checks passed
@vincent-lu
Copy link

Thanks guys!

@tectiv3
Copy link

tectiv3 commented Dec 5, 2024

This should've been at least a minor release change.

This package now suddenly requires gmp extension and that change definitely came unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated Property Warnings in EventWebhook Signature Verification with PHP 8.2
5 participants