fix: preserve substitutions from To in Personalization #1101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are substitutions in the To object preserve them by transfering them to the Personalization object.
Currently this does not work (we loose all substitutions from the To):
We can either add the substitution during
addTo
method (as current PR is proposing) or parse all Tos duringgetSubstitutions
method and add them to thesubstitution
property. I propose the first way because it is similar to what we have in https://github.com/sendgrid/sendgrid-php/blob/main/lib/mail/Mail.php#L205We have to also think about implementations that worked around this issue (like myself) and not break them, so the following must still be working :
OR we don't but we risk to break some implementations. Are there means of communicating the change in this case ?
Checklist