Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get rid of deprecation warnings regarding the first parameter of mb_convert_encoding #1081

Merged
merged 5 commits into from
Jul 29, 2022
Merged

fix: get rid of deprecation warnings regarding the first parameter of mb_convert_encoding #1081

merged 5 commits into from
Jul 29, 2022

Conversation

cclark61
Copy link
Contributor

@cclark61 cclark61 commented Feb 11, 2022 •
edited
Loading

Two small updates to fix php 8.1 deprecation warnings regarding the first parameter of mb_convert_encoding being required to be either a string or an array.

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added the necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

andreas-aeschlimann and others added 4 commits November 9, 2021 21:43
@andreas-aeschlimann
fix: suppress deprecation warnings in PHP 8.1
4a6bd12 
In PHP 8.1, we need to add the mixed return type to the jsonSerialize implementation. The mixed return type is not supported in older versions. It is possible to suppress the deprecation warning by adding a PHP attribute. Older PHP versions will interpret attributes as a comment.
@twilio-dx @shwetha-manvinkurke
[Librarian] Version Bump
bfe3ffe
@twilio-dx @shwetha-manvinkurke
Release 7.11.0
8852008
@cclark61
Two small updates to fix php 8.1 deprecation warnings regarding the f…
cbb3f56 
…irst parameter of mb_convert_encoding being required to be either a string or an array.
@childish-sambino childish-sambino changed the base branch from php8.1 to main July 29, 2022 21:13
@childish-sambino childish-sambino changed the title fix: Two small updates to fix php 8.1 deprecation warnings regarding the first parameter of mb_convert_encoding being required to be either a string or an array. fix: get rid of deprecation warnings regarding the first parameter of mb_convert_encoding Jul 29, 2022
@childish-sambino childish-sambino merged commit 115a470 into sendgrid:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclark61 @childish-sambino @andreas-aeschlimann @twilio-dx