Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing namespace for classes on test/unit folder #1030

Merged
merged 1 commit into from
Jan 21, 2021
Merged

fix: Fixing namespace for classes on test/unit folder #1030

merged 1 commit into from
Jan 21, 2021

Conversation

peter279k
Copy link
Contributor

Fixes

Fixing some classes namespaces and they should be SendGrid\Tests\Unit namespace.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 20, 2021
@peter279k peter279k force-pushed the fix_unit_test_namespace branch from 33ab688 to c3a0163 Compare January 20, 2021 07:11
@JenniferMah JenniferMah changed the title Fixing namespace for classes on test/unit folder fix: Fixing namespace for classes on test/unit folder Jan 21, 2021
JenniferMah
JenniferMah approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @peter279k!

@JenniferMah JenniferMah merged commit aa4705a into sendgrid:main Jan 21, 2021
@peter279k peter279k deleted the fix_unit_test_namespace branch January 22, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenniferMah JenniferMah JenniferMah approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter279k @JenniferMah @thinkingserious