Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix grammatical errors in README #827

Merged
merged 1 commit into from
Feb 13, 2020
Merged

docs: Fix grammatical errors in README #827

merged 1 commit into from
Feb 13, 2020

Conversation

chaman-1
Copy link
Contributor

Fixes

Checklist

  • [ X] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [X ] I have read the [Contribution Guide] and my PR follows them.
  • [X ] I updated my branch with the master branch.
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [ X] I have added necessary documentation about the functionality in the appropriate .md file
  • [X ] I have added inline documentation to the code I modified

Short description of what this PR does:

  • Fixed two gramatical errors in the README.md file

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2018
thinkingserious
thinkingserious requested changes Oct 29, 2018
View reviewed changes
README.md
@@ -48,7 +48,7 @@ This library is broken up into several packages as a monorepo so that you only n

All updates to this library are documented in our [CHANGELOG](https://github.com/sendgrid/sendgrid-nodejs/blob/master/CHANGELOG.md) and [releases](https://github.com/sendgrid/sendgrid-nodejs/releases). You may also subscribe to email [release notifications](https://dx.sendgrid.com/newsletter/nodejs) for releases and breaking changes.

Join an experienced and passionate team that focuses on making an impact. [Opportunities abound](https://sendgrid.com/careers) to grow the product - and grow your career!
Join the experienced and passionate team that focuses on making an impact. [Opportunities abound](https://sendgrid.com/careers) to grow the product - and grow your career!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, I think "an" reads better. Please revert this change. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'the' is used before definite articles, since the team mentioned above is specific(Sendgrid's team), I believe 'the' is appropriate.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 29, 2018
@thinkingserious
Copy link
Contributor

Hello @chaman-k,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @chaman-k,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino changed the title Fix gramatical errors docs: Fix grammatical errors in README Feb 13, 2020
@childish-sambino childish-sambino merged commit 7974cec into sendgrid:master Feb 13, 2020
@thinkingserious
Copy link
Contributor

Hello @chaman-1,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@commit-lint commit-lint bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious requested changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaman-1 @thinkingserious @childish-sambino @chaman-k