fix: update definitions for tsc 2.6, fixes #618

[phra]

i've updated the definitions files to support typescript 2.6. fixes #618

[SendGridDX]

All committers have signed the CLA.

[phra]

i'm still depending on quickfix in order to be able to deploy my project to production.. can you please merge this?

[thinkingserious]

@spartan563,

If you have a moment, a quick review would be much appreciated. Thanks!

[notheotherben]

Looks perfect to me 👍

[thinkingserious]

Awesome, this has been added to our backlog for final review and merge.

[phra]

@thinkingserious i've also sent #621 to fix the CI, i don't know if it's still required but 11 days ago was needed to make the CI work again.

[ShaharHD]

Been almost 3 weeks now. Any ETA on getting this small fix merged?
It does not have implications other than making this library usable in TS 2.6 from what I can see.

[joseSantacruz]

Hi, I also need to merge this PR to deploy to prod

[wwwy3y3]

+1 need this PR.
@thinkingserious any plan for this fix?

[thinkingserious]

Hello @ShaharHD @joseSantacruz @wwwy3y3,

This PR is on our backlog, which we are working through from oldest to newest. Our backlog is a bit overloaded because of Hacktoberfest, tub we are currently working to get caught up.

My apologies for the delay and I do appreciate your support and patience.

With Best Regards,

Elmer

[thinkingserious]

Thanks for taking the time to check it out @jdanyow!

[ShaharHD]

@thinkingserious Why wasn't this included in 6.2.0?

[phra]

hopefully i can continue to ship to production thanks to quickfix. ✌️

@ShaharHD @thinkingserious @spartan563 this PR should be merged ASAP because doesn't have any conflicts or regressions and fixes problems with typescript 2.6, so i don't see any reason to not merge this!

[thinkingserious]

Thanks @phra!

I have this on my list to deploy today.

[thinkingserious]

Hi @phra,

Before I merge this, could you please take a look at this recently merged PR to see if any further TypeScript changes are necessary? Thanks!

With Best Regards,

Elmer

[notheotherben]

It looks like there are some changes that are necessary to align it with the newly exported module spec. Specifically, rather than simply exporting Client, we should be exporting something like Client & { Client: typeof Client }. The same applies to the MailService export.

Should be a pretty easy fix.

[phra]

i will do it later today. 👍

[phra]

done. can you review the code? @thinkingserious @spartan563

[notheotherben]

Looks good to me 👍 thanks @phra

[thinkingserious]

Thanks to @phra and @spartan563 for being AWESOME and getting this done so quickly! I should have this deployed no later than tomorrow.

[bunnyvishal6]

@thinkingserious waiting for this pr to be merged. When will it be done?

[thinkingserious]

@bunnyvishal6,

I'm shooting for some time today.

[thinkingserious]

Hello @phra,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

[0x80]

Thanks for fixing this 👍 I can now set the compiler back to strict mode 😄

[thinkingserious]

Awesome, thanks for the comment @0x80!

[hansenst]

Hey @phra,
In commit 37c22e7 you forgot the typeof. @spartan563 suggested to add Client & { Client: typeof Client }, but you added only Client & { Client: Client } and that breaks the bindings.

[phra]

@hansenst at the time of committing, it was working properly. can you check it using tsc version ~2.6 ? i can eventually send another PR fixing it if it doesn't break v2.6 release or look for a solution that can work on tsc 2.6 and newer versions.

[hansenst]

Sorry @phra, I was somewhat unclear in my comment. Typescript itself is happy with the current types, but calling the setApiKey fails (it just gets stuck and eventually things time out). Changing the type definitions to Client & { Client: typeof Client } resolves the issue.

We're currently using TS 2.8.3.