Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unittest to check for specific repo files #568

Merged
merged 5 commits into from
Nov 1, 2017
Merged

Added unittest to check for specific repo files #568

merged 5 commits into from
Nov 1, 2017

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Oct 28, 2017 •
edited
Loading

Fixes #565

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mptap mptap force-pushed the add-test-files-exist branch from 862afd0 to fdb489d Compare October 28, 2017 18:47
@mptap mptap force-pushed the add-test-files-exist branch from fdb489d to be5e4c9 Compare October 28, 2017 18:50
@mbernier
Copy link
Contributor

@mptap
I think I might be blind - are you seeing the tests running here? https://travis-ci.org/sendgrid/sendgrid-nodejs/jobs/294203681

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
mbernier
mbernier suggested changes Oct 28, 2017
View reviewed changes
Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I figured it out - can you please do two things?

  1. Change the file name to test/files.spec.js
  2. Add the test to yarn like here

@mptap
Copy link
Contributor Author

mptap commented Oct 28, 2017

@mbernier: Done

@mptap mptap force-pushed the add-test-files-exist branch from 78c2d2c to 40e6b18 Compare October 28, 2017 19:49
@mptap mptap force-pushed the add-test-files-exist branch from 40e6b18 to 84eadb9 Compare October 28, 2017 19:50
@mbernier
Copy link
Contributor

mbernier commented Nov 1, 2017

Looks great, thank you!

@mbernier mbernier merged commit d777dc6 into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mptap @SendGridDX @mbernier @thinkingserious