Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma bug in name #448 #522

Merged
merged 3 commits into from
Oct 22, 2018
Merged

Comma bug in name #448 #522

merged 3 commits into from
Oct 22, 2018

Conversation

HeroProtagonist
Copy link
Contributor

Resolves #448

  • Wrap name in quotes if it contains a comma as suggested here
  • Add test cases

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 21, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 21, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
@thinkingserious
Copy link
Contributor

@HeroProtagonist

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

clee
clee reviewed Feb 14, 2018
View reviewed changes
Copy link

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee added status: code review complete and removed status: code review request requesting a community code review or review from Twilio labels Feb 14, 2018
@thinkingserious thinkingserious added type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit d39313a into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @HeroProtagonist,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2020
Merged
This was referenced Apr 17, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clee clee clee left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeroProtagonist @SendGridDX @thinkingserious @clee