Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the endpoint which allows the retrieval of all recipients #449

Merged
merged 2 commits into from
Nov 28, 2017

Conversation

Divya063
Copy link
Contributor

@Divya063 Divya063 commented Oct 3, 2017

closes #359

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 3, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 3, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 4, 2017
console.log(response.statusCode);
console.log(response.body);
console.log(response.headers);
});
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API has changed since that original issue was posted, now, it should be:

const queryParams = {
  'page': 1, 
  'page_size': 1
};
request.qs = queryParams;
request.method = 'GET';
var list_id = 1;
request.url = '/v3/contactdb/lists/{list_id}/recipients';
client.request(request)
.then(([response, body]) => {
  console.log(response.statusCode);
  console.log(response.body);
})

@thinkingserious
Copy link
Contributor

Hi @Divya063,

Just checking in to see if there is anything further you need from me to get this fixed.

Thank you!

With Best Regards,

Elmer

@Divya063
Copy link
Contributor Author

@thinkingserious I made the required changes

@thinkingserious
Copy link
Contributor

@Divya063

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious merged commit b592c53 into sendgrid:master Nov 28, 2017
@thinkingserious
Copy link
Contributor

Hello @Divya063,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

total items params not found in sendgrid nodejs all listing Api's
4 participants