fix: Support 204 response in axios

[lopenchi]

Fixes

Related PR: #1327

fix: Support 204 response in axios

Checklist

• I acknowledge that all my contributions will be made under the project's license
• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the Contribution Guidelines and my PR follows them
• I have titled the PR appropriately
• I have updated my branch with the main branch
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation about the functionality in the appropriate .md file
• I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

[bnb]

I'm pretty sure || status === 204 here is not ever going to be hit because if status is 204, the first condition will be met 👀

[lopenchi]

Yep but it is not working, you can see tests were skipped before. And it is how axios worked

[bnb]

I'm not sure I understand - if you don't include || status === 204 in this line, the tests fail?

[lopenchi]

yes, axios do not support 204 responses if this line is not added

[lopenchi]

check this related PR: #1327 where tests that returns 204 were skipped

[bnb]

Right, I understand. I'm not talking about the whole line, I'm specifically speaking about the contents of the line.

In code, here's what I mean:

const status = 204

console.log(status >= 200 && status < 300 || status === 204) // returns true

const status = 204

console.log(status >= 200 && status < 300) // returns true

both of these return true because if status is 204, status satisfies status >= 200 && status < 300, meaning that || status === 204 is a dead code path that will never be hit.

[lopenchi]

Got it! So I think this change is not needed.

What about not skipping the tests ? I think it has been already fixed in axios or prism

[bnb]

I think the change might still be needed - not sure either way! If it is, this line specifically should be tweaked so we're not shipping a dead code path that will never be executed. The solution to my original comment would be to simply drop || status === 204 from the line.