-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sanity-check email address and address lists when adding to a message #981
feat: sanity-check email address and address lists when adding to a message #981
Conversation
Context: sendgrid#980 When sending an email and providing an empty list of BCCs the request fails with BadRequest as outlined here: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.bcc We want to inform the consumer that this is the case otherwise it may lead to email sending silenty failing.
It looks like AddCC and other methods have the same issue, whilst I'm here I'll fix those too - hope that's okay? Indy |
Think I'm done :) Indy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @indy-singh, |
Any idea when the updated package will be available in nuget?
*@childish-sambino*
…On Wed, 26 Feb 2020, 20:44 childish-sambino, ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#981?email_source=notifications&email_token=AAORQWWF3AIARNCM3AYNAXTRE3ICTA5CNFSM4K4MWULKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXCO6EA#pullrequestreview-365227792>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAORQWX5JC2JBBT2KGZZK6DRE3ICTANCNFSM4K4MWULA>
.
|
Next scheduled release is for 2020-03-04. |
Is the updated sdk still being rolled out today?
…On Wed, 26 Feb 2020, 21:24 childish-sambino, ***@***.***> wrote:
Next scheduled release is for 2020-03-04.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#981?email_source=notifications&email_token=AAORQWTDPN5CCAXWIJJIYBLRE3MZHA5CNFSM4K4MWULKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENB6FFQ#issuecomment-591651478>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAORQWQLPCXGETMQWXY7RO3RE3MZHANCNFSM4K4MWULA>
.
|
Yup, noon-ish pacific time typically. |
Fixes #980
When sending an email and providing an empty list of BCCs the request fails with BadRequest as outlined here: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.bcc
We want to inform the consumer that this is the case otherwise it may lead to email sending silenty failing.
Fixes
Checklist
Short description of what this PR does:
Pre send email validation to enforce the rules found here: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.bcc