Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#638 Add default value for SubstitutionTag parameter #700

Conversation

KoditkarVedant
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • The SendGridMessage has the SetOpenTracking which takes two arguments enable and substitutionTag. The substitutionTag argument is optional and if user don't want to use it currently, they need to pass null explicitly as we have it as required. So I've set it to have default null value.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 16, 2018
@SendGridDX
Copy link

SendGridDX commented Jun 16, 2018

CLA assistant check
All committers have signed the CLA.

@KoditkarVedant
Copy link
Contributor Author

Hello @thinkingserious, can you please look into this PR?

@thinkingserious
Copy link
Contributor

This PR LGTM. It's now on our backlog for merging. Thanks!

@jpurpura jpurpura added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: ready for deploy code ready to be released in next deploy labels Aug 13, 2018
@thinkingserious thinkingserious merged commit 2c23a6a into sendgrid:master Aug 21, 2018
@thinkingserious
Copy link
Contributor

Hello @KoditkarVedant,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants