Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unittest to check for specific repo files #609

Merged
merged 5 commits into from
Nov 22, 2017
Merged

Added unittest to check for specific repo files #609

merged 5 commits into from
Nov 22, 2017

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Oct 28, 2017 •
edited
Loading

Fixes #607

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mptap mptap mentioned this pull request Oct 28, 2017
Closed
@mbernier mbernier added the difficulty: medium fix is medium in difficulty label Nov 17, 2017
@mbernier mbernier merged commit 8e33b98 into sendgrid:master Nov 22, 2017
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files
4 participants
@mptap @SendGridDX @thinkingserious @mbernier