Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IsSuccessStatusCode #1077

Merged
merged 2 commits into from
Dec 14, 2020
Merged

feat: add IsSuccessStatusCode #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b506de8
feat: add IsSuccessStatusCode
shoter Dec 13, 2020
b624b77
feat: add tests
shoter Dec 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/SendGrid/Response.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ public HttpStatusCode StatusCode
}
}

/// <summary>
/// Gets a value indicating whether Status Code of this response indicates success.
/// </summary>
public bool IsSuccessStatusCode
{
get { return ((int)StatusCode >= 200) && ((int)StatusCode <= 299); }
}

/// <summary>
/// Gets or sets the response body returned from Twilio SendGrid.
/// </summary>
Expand Down
29 changes: 29 additions & 0 deletions tests/SendGrid.Tests/Integration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Collections.Generic;
using System.Net;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -2725,6 +2726,7 @@ public void TestSetGoogleAnalytics()
msg.SetGoogleAnalytics(true, "campaign3", "content3", "medium3", "source3", "term3");
Assert.Equal("{\"tracking_settings\":{\"ganalytics\":{\"enable\":true,\"utm_source\":\"source3\",\"utm_medium\":\"medium3\",\"utm_term\":\"term3\",\"utm_content\":\"content3\",\"utm_campaign\":\"campaign3\"}}}", msg.Serialize());
}

[Fact]
public async Task TestAccessSettingsActivityGet()
{
Expand Down Expand Up @@ -6004,6 +6006,33 @@ public void TestInjectSameHttpClientWithMultipleInstance()
var sg1 = new SendGridClient(clientToInject, fixture.apiKey);
var sg2 = new SendGridClient(clientToInject, fixture.apiKey);
}

[Fact]
public void TestBadRequestIsSuccessStatusCodeReturnsFalse()
{
var message = new HttpResponseMessage();
var response = new Response(HttpStatusCode.BadRequest, message.Content, message.Headers);
Assert.False(response.IsSuccessStatusCode);
}

[Fact]
public void TestOkRequestIsSuccessStatusCodeReturnsTrue()
{
var message = new HttpResponseMessage();
var response = new Response(HttpStatusCode.OK, message.Content, message.Headers);
Assert.True(response.IsSuccessStatusCode);
}

[Fact]
public void TestIsSuccessStatusCodeEvery2xxCodeReturnsTrue()
{
for (int i = 200; i <= 299; ++i)
{
var message = new HttpResponseMessage();
var response = new Response((HttpStatusCode)i, message.Content, message.Headers);
Assert.True(response.IsSuccessStatusCode);
}
}
}

public class FakeWebProxy : IWebProxy
Expand Down